Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add load-test end-to-end example #57

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rjeczalik
Copy link
Member

fixes #40

@tzach
Copy link
Contributor

tzach commented Feb 1, 2023

@rjeczalik I'm missing something: where do you define the number of type of the loader VMs?

@rjeczalik
Copy link
Member Author

rjeczalik commented Feb 1, 2023

@tzach Here's the relevant part:

module "scylla-bench" {
	source    = "github.com/rjeczalik/terraform-aws-scylla-bench"
	username  = data.scylladbcloud_cql_auth.mycluster.username
	password  = data.scylladbcloud_cql_auth.mycluster.password
	seeds     = split(",", data.scylladbcloud_cql_auth.mycluster.seeds)
	instances = 4
	keys      = 1000000000
	limit     = 10000

	depends_on = [aws_route_table.bench]
}

By default aws_instance_type is c4.large and can be changed to anything else. Number of instances is set by instances variable.

@tzach
Copy link
Contributor

tzach commented Feb 1, 2023

By default aws_instance_type is c4.large

Where is this default? could not find it in the code

@charconstpointer
Copy link
Contributor

By default aws_instance_type is c4.large

Where is this default? could not find it in the code

https://github.com/rjeczalik/terraform-aws-scylla-bench/blob/469d1adcecc25884885edabc5f9e2437194bece1/variables.tf#L3

right there within the bench module, @tzach

Comment on lines +19 to +28
resource "scylladbcloud_cluster" "mycluster" {
name = "Load Test"
byoa_id = 1002
region = "us-east-1"
node_count = 3
node_type = "i3.xlarge"
cidr_block = "172.31.0.0/16"

enable_vpc_peering = true
enable_dns = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is byoa_id and enable_dns needed for this example? I would keep it as simple as possible

Copy link
Contributor

@charconstpointer charconstpointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rayakurl
Copy link

@ilya-rarov - FYI, this one will require testing. I'll talk to you about the priority.

@tzach
Copy link
Contributor

tzach commented Mar 5, 2023

Any update on this PR? It woulkd be great to merge it (once ready)

@rjeczalik
Copy link
Member Author

rjeczalik commented Mar 14, 2023

Any update on this PR?

@tzach I am waiting for test results from QA, regardless I will try to push it further later this week. 🤞

@tzach
Copy link
Contributor

tzach commented Apr 13, 2023

I suggest moving forward and merging this. Its just too helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples: add a benchmark end-to-end example
4 participants